[
https://issues.apache.org/jira/browse/BEAM-6935?focusedWorklogId=223179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223179
]
ASF GitHub Bot logged work on BEAM-6935:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 18:11
Start Date: 04/Apr/19 18:11
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #8220: [BEAM-6935]
Spark portable runner: implement side inputs
URL: https://github.com/apache/beam/pull/8220#discussion_r272303633
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/BoundedDataset.java
##########
@@ -69,6 +70,14 @@
return rdd;
}
+ List<byte[]> getBytes(WindowedValue.WindowedValueCoder<T> wvCoder) {
+ if (clientBytes == null) {
+ JavaRDDLike<byte[], ?> bytesRDD =
rdd.map(CoderHelpers.toByteFunction(wvCoder));
+ clientBytes = bytesRDD.collect();
Review comment:
I would ideally make these method stateless but I think its fine for now as
its the same in getValue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 223179)
Time Spent: 40m (was: 0.5h)
> Spark Portable Runner: Support side inputs
> ------------------------------------------
>
> Key: BEAM-6935
> URL: https://issues.apache.org/jira/browse/BEAM-6935
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
