[ https://issues.apache.org/jira/browse/BEAM-13930?focusedWorklogId=726730&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726730 ]
ASF GitHub Bot logged work on BEAM-13930: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/Feb/22 00:05 Start Date: 15/Feb/22 00:05 Worklog Time Spent: 10m Work Description: codecov[bot] edited a comment on pull request #16852: URL: https://github.com/apache/beam/pull/16852#issuecomment-1039699070 # [Codecov](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#16852](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a06200) into [release-2.37.0](https://codecov.io/gh/apache/beam/commit/76a3b3762f834e37d542c5eaf2bf2ec2f8db0eca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76a3b37) will **increase** coverage by `36.81%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## release-2.37.0 #16852 +/- ## =================================================== + Coverage 46.79% 83.60% +36.81% =================================================== Files 203 452 +249 Lines 20044 62269 +42225 =================================================== + Hits 9379 52063 +42684 - Misses 9665 10206 +541 + Partials 1000 0 -1000 ``` | [Impacted Files](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <100.00%> (ø)` | | | [sdks/python/apache\_beam/transforms/userstate.py](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91c2Vyc3RhdGUucHk=) | `84.84% <100.00%> (ø)` | | | [sdks/go/pkg/beam/transforms/top/top.shims.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL3RvcC90b3Auc2hpbXMuZ28=) | | | | [sdks/go/pkg/beam/core/runtime/types.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvdHlwZXMuZ28=) | | | | [sdks/go/pkg/beam/core/funcx/sideinput.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2Z1bmN4L3NpZGVpbnB1dC5nbw==) | | | | [sdks/go/pkg/beam/core/graph/coder/map.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL21hcC5nbw==) | | | | [...ks/go/pkg/beam/core/runtime/harness/cache\_hooks.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9jYWNoZV9ob29rcy5nbw==) | | | | [sdks/go/pkg/beam/io/databaseio/database.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9kYXRhYmFzZWlvL2RhdGFiYXNlLmdv) | | | | [sdks/go/pkg/beam/testing/passert/passert.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90ZXN0aW5nL3Bhc3NlcnQvcGFzc2VydC5nbw==) | | | | [.../pkg/beam/runners/dataflow/dataflowlib/messages.go](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL21lc3NhZ2VzLmdv) | | | | ... and [647 more](https://codecov.io/gh/apache/beam/pull/16852/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [76a3b37...8a06200](https://codecov.io/gh/apache/beam/pull/16852?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 726730) Time Spent: 1h 10m (was: 1h) > Address StateSpec inconsistency between Runner and Fn API > --------------------------------------------------------- > > Key: BEAM-13930 > URL: https://issues.apache.org/jira/browse/BEAM-13930 > Project: Beam > Issue Type: Improvement > Components: beam-model, sdk-java-core, sdk-py-core > Reporter: Luke Cwik > Assignee: Luke Cwik > Priority: P2 > Time Spent: 1h 10m > Remaining Estimate: 0h > > The ability to mix and match runners and SDKs is accomplished through two > portability layers: > 1. The Runner API provides an SDK-and-runner-independent definition of a Beam > pipeline > 2. The Fn API allows a runner to invoke SDK-specific user-defined functions > Apache Beam pipelines support executing stateful DoFns[1]. To support this > execution the Runner API defines multiple user state specifications: > * ReadModifyWriteStateSpec > * BagStateSpec > * OrderedListStateSpec > * CombiningStateSpec > * MapStateSpec > * SetStateSpec > The Fn API[2] defines APIs[3] to get, append and clear user state currently > supporting a BagUserState and MultimapUserState protocol. > Since there is no clear mapping between the Runner API and Fn API state > specifications, there is no way for a runner to know that it supports a given > API necessary to support the execution of the pipeline. The Runner will also > have to manage additional runtime metadata associated with which protocol was > used for a type of state so that it can successfully manage the state’s > lifetime once it can be garbage collected. > Please see the doc[4] for further details and a proposal on how to address > this shortcoming. > 1: https://beam.apache.org/blog/stateful-processing/ > 2: > https://github.com/apache/beam/blob/3ad05523f4cdf5122fc319276fcb461f768af39d/model/fn-execution/src/main/proto/beam_fn_api.proto#L742 > 3: https://s.apache.org/beam-fn-state-api-and-bundle-processing > 4: http://doc/1ELKTuRTV3C5jt_YoBBwPdsPa5eoXCCOSKQ3GPzZrK7Q -- This message was sent by Atlassian Jira (v8.20.1#820001)