Robert Burke created BEAM-7009:
----------------------------------

             Summary: Add Go SDK test for Standard Coders using the yaml data.
                 Key: BEAM-7009
                 URL: https://issues.apache.org/jira/browse/BEAM-7009
             Project: Beam
          Issue Type: Bug
          Components: beam-model, sdk-go
            Reporter: Robert Burke


The Go SDK doesn't currently do this validation, against the standard yaml 
file. [1]
The Java and Python equivalents of the test can be found from here [2].
 
Care would need to be taken so that Beam Go SDK users (such as they are) aren't 
forced to run them, and not have the yaml file to read. I'd suggest putting it 
with the integration tests [3].

The other thing of note is that the Go SDK has no notion of "nested" vs 
"unnested" coders. All coders are "nested" in the Go SDK, and should have their 
lengths prefixed to them as appropriate.


1: 
[https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml]
2: 
[https://github.com/apache/beam/search?q=standard_coders.yaml&unscoped_q=standard_coders.yaml]
3: [https://github.com/apache/beam/tree/master/sdks/go/test 
|https://github.com/apache/beam/tree/master/sdks/go/test]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to