[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=727526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-727526
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/22 18:58
Start Date: 15/Feb/22 18:58
Worklog Time Spent: 10m
Work Description: hengfengli commented on a change in pull request #16845:
URL: https://github.com/apache/beam/pull/16845#discussion_r806318809
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -1496,8 +1505,10 @@ public ReadChangeStream
withTraceSampleProbability(Double probability) {
getMetadataInstance(),
changeStreamDatabaseId.getInstanceId().getInstance());
final String partitionMetadataDatabaseId =
MoreObjects.firstNonNull(getMetadataDatabase(),
changeStreamDatabaseId.getDatabase());
- final String partitionMetadataTableName =
- generatePartitionMetadataTableName(partitionMetadataDatabaseId);
+ String partitionMetadataTableName = getMetadataTableName();
Review comment:
Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 727526)
Time Spent: 19h 50m (was: 19h 40m)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Priority: P3
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
