[
https://issues.apache.org/jira/browse/BEAM-13870?focusedWorklogId=727570&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-727570
]
ASF GitHub Bot logged work on BEAM-13870:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/22 19:02
Start Date: 15/Feb/22 19:02
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16826:
URL: https://github.com/apache/beam/pull/16826#discussion_r806005417
##########
File path: playground/backend/internal/cache/local/local_cache_test.go
##########
@@ -103,6 +105,23 @@ func TestLocalCache_GetValue(t *testing.T) {
want: nil,
wantErr: true,
},
+ {
+ // Test case with calling GetValue method with exist
value the expiration time of which has ended.
+ // As a result, want to receive an error.
Review comment:
Thank you for adding these comments, could you please also add comments
for other tests in these files? So every test in `local_cache_test.go` and
`redis_cache_test.go` has a corresponding comment😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 727570)
Time Spent: 50m (was: 40m)
> [Playground] Increase test coverage for the cache package
> ---------------------------------------------------------
>
> Key: BEAM-13870
> URL: https://issues.apache.org/jira/browse/BEAM-13870
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Pavel Avilov
> Priority: P3
> Labels: beam-playground-backend
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Need to add unit tests to increase test coverage for the _cache_ package
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
