[
https://issues.apache.org/jira/browse/BEAM-6753?focusedWorklogId=223313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223313
]
ASF GitHub Bot logged work on BEAM-6753:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 22:42
Start Date: 04/Apr/19 22:42
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7952:
[BEAM-6753] Set the stage to make schema coder update compatible
URL: https://github.com/apache/beam/pull/7952#discussion_r272394224
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -635,6 +635,61 @@ message StandardCoders {
}
}
+// Experimental: A representation of a Beam Schema.
+message Schema {
+ enum TypeName {
+ BYTE = 0;
+ INT16 = 1;
+ INT32 = 2;
+ INT64 = 3;
+ DECIMAL = 4;
+ FLOAT = 5;
+ DOUBLE = 6;
+ STRING = 7;
+ DATETIME = 8;
+ BOOLEAN = 9;
+ BYTES = 10;
+ ARRAY = 11;
+ MAP = 13;
Review comment:
Notably, you don't need this. `FieldType` has a oneof and one of the
alternatives can be an atomic type and the others are map, row, array, logical.
I would recommend breaking out more types in this oneof, for example a
BytesTypes we may likely want metadata indicating a coder. And we discussed -
and I think should go ahead with - removing datetime as a primitive type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223313)
Time Spent: 2h 20m (was: 2h 10m)
> Create proto representation for schemas
> ---------------------------------------
>
> Key: BEAM-6753
> URL: https://issues.apache.org/jira/browse/BEAM-6753
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
