[ 
https://issues.apache.org/jira/browse/BEAM-12877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493337#comment-17493337
 ] 

Alexey Romanenko edited comment on BEAM-12877 at 2/16/22, 4:36 PM:
-------------------------------------------------------------------

[~kegelink] Are you going to add your patch as a pull request? If yes then you 
can find some details on this 
[here|https://beam.apache.org/contribute/#make-your-change].


was (Author: aromanenko):
[~kegelink] Are you going to add your path as a pull request? If yes then you 
can find some details on this 
[here|https://beam.apache.org/contribute/#make-your-change].

> Beam Row Avro conversion: fixed and bytes decimals
> --------------------------------------------------
>
>                 Key: BEAM-12877
>                 URL: https://issues.apache.org/jira/browse/BEAM-12877
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>    Affects Versions: 2.32.0
>            Reporter: Koen Egelink
>            Assignee: Koen Egelink
>            Priority: P2
>              Labels: stale-assigned
>         Attachments: beam-sdks-java-core-2.32.0-fixed-decimal.patch
>
>
> An Avro decimal logical type annotates Avro bytes or fixed types.
> Current Row to Avro conversion is limited to bytes type and in addition 
> hardcodes precision to MAX_INT and scale to 0. 
> I have attached a patch that adds support for decimal bytes and fixed types.
> I could think of 2 possible ways to solve this:
>  # Change Row decimal type to a logical type
>  # Use Beam field options to pass additional metadata required to serialize 
> decimals
> I felt that overhauling Beam schema types might not be a good idea. Instead I 
> went with option 2.
> Passes ./gradlew check
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to