[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=223345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223345
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 23:03
Start Date: 04/Apr/19 23:03
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8229: [BEAM-3545]
Support Metrics in Go SDK CombineFns- Part 2
URL: https://github.com/apache/beam/pull/8229#discussion_r272398437
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -148,6 +157,7 @@ func mustExplodeWindows(fn *funcx.Fn, elm *FullValue,
usesSideInput bool) bool {
return explode || usesSideInput
}
+// FinishBundle finishes processing for this bundle and does post bundle
processing operations.
Review comment:
Oh yeah, that looks way better than my suggestion :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 223345)
Time Spent: 13.5h (was: 13h 20m)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: portability, triaged
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
