[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=729030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729030
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/22 15:37
Start Date: 17/Feb/22 15:37
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #16853:
URL: https://github.com/apache/beam/pull/16853#discussion_r809184204
##########
File path: sdks/python/apache_beam/examples/cookbook/coders_test.py
##########
@@ -78,24 +94,23 @@ def test_compute_points(self):
@pytest.mark.examples_postcommit
def test_coders_output_files_on_small_input(self):
test_pipeline = TestPipeline(is_integration_test=True)
-
# Setup the files with expected content.
- temp_folder = tempfile.mkdtemp()
- self.create_content_input_file(
- os.path.join(temp_folder, 'input.txt'),
- '\n'.join(map(json.dumps, self.SAMPLE_RECORDS)))
- extra_opts = {
- 'input': '%s/input.txt' % temp_folder,
- 'output': os.path.join(temp_folder, 'result')
- }
+ OUTPUT_FILE_DIR = \
Review comment:
I think unit tests should be light-weight and not require credentials to
apache-beam-testing. integration tests may need that access.
We can separate integration tests into _it_test files, or mark them a
postcommits within the same test file. My preference is the former but I think
we have instances of both, so no strong opinion on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729030)
Time Spent: 55h 40m (was: 55.5h)
> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 55h 40m
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
