[
https://issues.apache.org/jira/browse/BEAM-13681?focusedWorklogId=729187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729187
]
ASF GitHub Bot logged work on BEAM-13681:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/22 19:26
Start Date: 17/Feb/22 19:26
Worklog Time Spent: 10m
Work Description: damondouglas commented on a change in pull request
#16549:
URL: https://github.com/apache/beam/pull/16549#discussion_r809394560
##########
File path: playground/terraform/infrastructure/gke/main.tf
##########
@@ -18,28 +17,24 @@
# under the License.
#
-terraform {
- backend "gcs" {
- bucket = "playground_terraform"
- }
-}
+
resource "google_container_cluster" "playground-gke" {
- name = "playground-examples"
- project = "${var.project_id}"
- location = "us-central1-a"
- initial_node_count = "${var.node_count}"
+ name = var.gke_name
+ project = var.project_id
+ location = var.gke_location
+ initial_node_count = var.gke_node_count
node_config {
- machine_type = "${var.machine_type}"
- service_account = "${var.service_account}"
+ machine_type = var.gke_machine_type
+ service_account = var.service_account
- oauth_scopes = [
+ oauth_scopes = [
"https://www.googleapis.com/auth/cloud-platform"
]
- labels = {
- component = "beam-playground"
+ labels = {
+ component = "beam-playground"
}
- tags = ["beam-playground"]
+ tags = ["beam-playground"]
Review comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729187)
Time Spent: 4h 20m (was: 4h 10m)
> [Playground] Refactoring of infrastructure terraform scripts
> ------------------------------------------------------------
>
> Key: BEAM-13681
> URL: https://issues.apache.org/jira/browse/BEAM-13681
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Andrey Kustov
> Priority: P2
> Labels: beam-playground-devops
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Come up with the following terraform structure:
> # Distinguish modules (vpc, artifact_registry , memorystore (redis), bucket,
> Kubernet)
> # Implement the description of the modules as a script
> # Introduce module dependencies (vpc -> buckets -> artifact_registry ->
> memorystore -> gke)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)