[
https://issues.apache.org/jira/browse/BEAM-10608?focusedWorklogId=729432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729432
]
ASF GitHub Bot logged work on BEAM-10608:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 05:18
Start Date: 18/Feb/22 05:18
Worklog Time Spent: 10m
Work Description: kmjung commented on a change in pull request #16721:
URL: https://github.com/apache/beam/pull/16721#discussion_r809680632
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageSourceBase.java
##########
@@ -63,15 +64,15 @@
*/
private static final int MIN_SPLIT_COUNT = 10;
- protected final DataFormat format;
+ protected final @Nullable DataFormat format;
Review comment:
From an API perspective, this shouldn't be nullable -- it's required in
the v1 API.
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -90,14 +90,7 @@
import io.grpc.Status.Code;
import io.grpc.protobuf.ProtoUtils;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
Review comment:
Is this compliant with the style guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729432)
Time Spent: 50m (was: 40m)
> Eliminate nullability errors from :sdks:java:io:google-cloud-platform
> ---------------------------------------------------------------------
>
> Key: BEAM-10608
> URL: https://issues.apache.org/jira/browse/BEAM-10608
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-gcp
> Reporter: Kenneth Knowles
> Priority: P3
> Labels: starter
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some
> errors!
> As of 2020-07-20 setting {{-Xmaxerrs 10000}} there are 1451 errors in the
> core Java SDK.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
