[
https://issues.apache.org/jira/browse/BEAM-13963?focusedWorklogId=729577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729577
]
ASF GitHub Bot logged work on BEAM-13963:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 10:40
Start Date: 18/Feb/22 10:40
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16880:
URL: https://github.com/apache/beam/pull/16880#discussion_r809879368
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -229,7 +228,11 @@ func (cd *CloudStorage) getPrecompiledObjectsDirs(ctx
context.Context, targetSdk
break
}
if err != nil {
- return nil, fmt.Errorf("Bucket(%q).Objects: %v",
BucketName, err)
+ bucketAttrs, errWithAttrs := bucket.Attrs(ctx)
+ if errWithAttrs != nil {
+ return nil, fmt.Errorf("rrror during receiving
bucket's attributes: %s", err)
Review comment:
```suggestion
return nil, fmt.Errorf("Error during receiving
bucket's attributes: %s", err)
```
##########
File path: playground/backend/internal/environment/application.go
##########
@@ -99,17 +99,21 @@ type ApplicationEnvs struct {
// pipelinesFolder is name of folder in which the pipelines resources
are stored
pipelinesFolder string
+
+ // bucketName is a name of the GCS's bucket
Review comment:
```suggestion
// bucketName is a name of the GCS bucket with examples
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729577)
Time Spent: 0.5h (was: 20m)
> [Playground] Get bucket name from environment variable
> ------------------------------------------------------
>
> Key: BEAM-13963
> URL: https://issues.apache.org/jira/browse/BEAM-13963
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Aydar Zaynutdinov
> Priority: P2
> Labels: beam-playground-backend
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Now, the backend has a hardcoded bucket name in
> playground/backend/internal/cloud_bucket/precompiled_objects.go
> It needs to be changed to be taken from the environment variable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
