[
https://issues.apache.org/jira/browse/BEAM-13796?focusedWorklogId=729910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729910
]
ASF GitHub Bot logged work on BEAM-13796:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 22:42
Start Date: 18/Feb/22 22:42
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #16720:
URL: https://github.com/apache/beam/pull/16720#discussion_r810383651
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageQueryTest.java
##########
@@ -753,6 +762,31 @@ public void testQuerySourceCreateReader() throws Exception
{
querySource.createReader(options);
}
+ @Test
+ public void testActuateProjectionPushdown() {
+ org.apache.beam.sdk.schemas.Schema schema =
+ org.apache.beam.sdk.schemas.Schema.builder()
+ .addStringField("foo")
+ .addStringField("bar")
+ .build();
+ TypedRead<Row> read =
+ BigQueryIO.read(
+ record ->
+ BigQueryUtils.toBeamRow(
+ record.getRecord(), schema,
ConversionOptions.builder().build()))
+ .withMethod(Method.DIRECT_READ)
+ .withCoder(SchemaCoder.of(schema));
Review comment:
You're right. It was confusing because the two classes had the exact
same javadoc. I moved the tests and updated the javadoc according to my
understanding of the author's intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729910)
Time Spent: 1h 20m (was: 1h 10m)
> Projection pushdown in BigQuery IO
> ----------------------------------
>
> Key: BEAM-13796
> URL: https://issues.apache.org/jira/browse/BEAM-13796
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> BigQuery IO (read API only) already supports pushdown within Beam SQL
> queries, but we want to support pushdown outside of just SQL.
> To do this, BigQuery Read needs to implement ProjectionProducer.
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/ProjectionProducer.java
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
