[
https://issues.apache.org/jira/browse/BEAM-13857?focusedWorklogId=729959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729959
]
ASF GitHub Bot logged work on BEAM-13857:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/22 01:33
Start Date: 19/Feb/22 01:33
Worklog Time Spent: 10m
Work Description: youngoli opened a new pull request #16908:
URL: https://github.com/apache/beam/pull/16908
Adds functionality for running jars to the Go integration test framework,
and uses this functionality to implement handling of K:V flags for providing
expansion service jars and addresses to the test framework. This means that
tests can simply get the address of an expansion service with the appropriate
label, and this feature will handle running a jar if necessary, or just using
the passed in endpoint otherwise.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/validate-runner/README.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729959)
Remaining Estimate: 0h
Time Spent: 10m
> Add expansion service startup to Go integration test flags.
> -----------------------------------------------------------
>
> Key: BEAM-13857
> URL: https://issues.apache.org/jira/browse/BEAM-13857
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently a separate debezium io expansion address flag needs to be passed to
> the runner when running cross-language debezium IO pipelines from Go SDK.
> Find a way to do this in a better way so that we could have it started along
> with java io expansion service while spinning up the test without bulking
> :sdks:java:io:expansion-service.
> In particular, needing to add a flag per expansion service jar to our
> integration tests will eventually become quite cluttered, so we may wish to
> settle on some kind of KV map flag approach instead to reduce copypasta code
> overhead.
> Edit: Decided on going with the KV map flag approach within the Go SDK
> instead of in a bash script, and moving expansion service startup into the
> codebase as well.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
