[
https://issues.apache.org/jira/browse/BEAM-6964?focusedWorklogId=223613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223613
]
ASF GitHub Bot logged work on BEAM-6964:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/19 14:52
Start Date: 05/Apr/19 14:52
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8190: [BEAM-6964]
Simplify key context handling in ExecutableStageDoFnOperator
URL: https://github.com/apache/beam/pull/8190#discussion_r272621787
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtils.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink.translation.wrappers.streaming;
+
+import static
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkNotNull;
+import static
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkState;
+
+import java.nio.ByteBuffer;
+import java.util.Arrays;
+import java.util.Locale;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.util.CoderUtils;
+
+/**
+ * Utility functions for dealing with key encoding. Beam requires keys to be
compared in binary
+ * format. The helpers here ensure that a consistent encoding is used.
+ */
+class FlinkKeyUtils {
+
+ /** Encodes a key to a byte array wrapped inside a ByteBuffer. */
+ static <K> ByteBuffer encodeKey(K key, Coder<K> keyCoder) {
+ checkNotNull(keyCoder, "Provided coder must not be null");
+ final byte[] keyBytes;
+ try {
+ keyBytes = CoderUtils.encodeToByteArray(keyCoder, key);
+ } catch (Exception e) {
+ throw new RuntimeException(String.format(Locale.ENGLISH, "Failed to
encode key: %s", key), e);
+ }
+ return ByteBuffer.wrap(keyBytes);
+ }
+
+ /** Decodes a key from a ByteBuffer containing a byte array. */
+ static <K> K decodeKey(ByteBuffer byteBuffer, Coder<K> keyCoder) {
+ checkNotNull(byteBuffer, "Provided ByteBuffer must not be null");
+ checkNotNull(keyCoder, "Provided coder must not be null");
+ checkState(byteBuffer.hasArray(), "ByteBuffer key must contain an array.");
+ @SuppressWarnings("ByteBufferBackingArray")
Review comment:
isn't there a way to avoid this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 223613)
Time Spent: 1h (was: 50m)
> Simplify key context handling in ExecutableStageDoFnOperator
> ------------------------------------------------------------
>
> Key: BEAM-6964
> URL: https://issues.apache.org/jira/browse/BEAM-6964
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The code is a bit hard to understand because of multiple keys being set in
> different contexts, for 1) state requests 2) timers setting 3) timer firing.
> This should be simplified.
> We can also introduce a helper class for key encoding/decoding to achieve
> consistency across all places which use a key serializer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
