[
https://issues.apache.org/jira/browse/BEAM-13884?focusedWorklogId=731179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731179
]
ASF GitHub Bot logged work on BEAM-13884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/22 21:26
Start Date: 22/Feb/22 21:26
Worklog Time Spent: 10m
Work Description: jrmccluskey opened a new pull request #16924:
URL: https://github.com/apache/beam/pull/16924
Add unit tests to cover expected behavior of mtime package functions, remove
`n2m()` function in favor of using the `time` package's millisecond functions.
Unit tests were added first to ensure that the slight refactor did not break
expected behavior at boundaries.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 731179)
Remaining Estimate: 0h
Time Spent: 10m
> Add unit testing to mtime package
> ---------------------------------
>
> Key: BEAM-13884
> URL: https://issues.apache.org/jira/browse/BEAM-13884
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Labels: starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add basic unit tests to the [mtime
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/core/graph/mtime]
> We want to have code coverage at or above 50%, it is currently at 0%.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
