[
https://issues.apache.org/jira/browse/BEAM-13709?focusedWorklogId=731977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731977
]
ASF GitHub Bot logged work on BEAM-13709:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/22 22:21
Start Date: 23/Feb/22 22:21
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16929:
URL: https://github.com/apache/beam/pull/16929#issuecomment-1049144362
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16929](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(10cff75) into
[master](https://codecov.io/gh/apache/beam/commit/53dbd3266027f9ca8f3d62622a896fbf9940066d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(53dbd32) will **increase** coverage by `27.38%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16929 +/- ##
===========================================
+ Coverage 45.65% 73.03% +27.38%
===========================================
Files 204 657 +453
Lines 24190 86686 +62496
===========================================
+ Hits 11043 63308 +52265
- Misses 12147 22378 +10231
Partials 1000 1000
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.62% <88.23%> (?)` | |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `95.01% <88.23%> (ø)` | |
|
[sdks/python/apache\_beam/transforms/display.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9kaXNwbGF5LnB5)
| `94.03% <0.00%> (ø)` | |
|
[...ython/apache\_beam/portability/api/endpoints\_pb2.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjIucHk=)
| `100.00% <0.00%> (ø)` | |
|
[...on/apache\_beam/ml/gcp/naturallanguageml\_test\_it.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL25hdHVyYWxsYW5ndWFnZW1sX3Rlc3RfaXQucHk=)
| `69.23% <0.00%> (ø)` | |
|
[...hon/apache\_beam/runners/worker/worker\_pool\_main.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3Bvb2xfbWFpbi5weQ==)
| `59.25% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGltZXN0YW1wLnB5)
| `96.31% <0.00%> (ø)` | |
|
[...examples/snippets/transforms/elementwise/kvswap.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9rdnN3YXAucHk=)
| `100.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/io/aws/s3filesystem.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL3MzZmlsZXN5c3RlbS5weQ==)
| `77.55% <0.00%> (ø)` | |
|
[...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfdG9ybmFkb2VzLnB5)
| `42.10% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaGlzdG9ncmFtLnB5)
| `93.33% <0.00%> (ø)` | |
| ... and [444
more](https://codecov.io/gh/apache/beam/pull/16929/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[53dbd32...10cff75](https://codecov.io/gh/apache/beam/pull/16929?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 731977)
Time Spent: 4h 40m (was: 4.5h)
> PipelineOptions() and from_dictionary parsing use_public_ips and
> no_use_public_ips differently
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-13709
> URL: https://issues.apache.org/jira/browse/BEAM-13709
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Minbo Bae
> Assignee: Anand Inguva
> Priority: P2
> Labels: starter, usability
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> {{PipelineOptions}} in Python has two methods to pass a param dict: using in
> constructor {{PipelineOptions(**params)}} or
> {{{}PipelineOptions.from_dictionary(params){}}}.
> But, they work slightly differently:
> *
> [PipelineOptions(**params)|https://github.com/apache/beam/blob/v2.35.0/sdks/python/apache_beam/options/pipeline_options.py#L313-L324]
> discards an option if it is not defined as a dest of {{argparse}} in an
> Option class. For example, {{no_use_public_ips=True}} is ignored and the
> Dataflow job will run with public IPs. To disable public IPs, the option
> dictionary must use {{{}use_public_ips{}}}.
> *
> [PipelineOptions.from_dictionary()|https://github.com/apache/beam/blob/v2.35.0/sdks/python/apache_beam/options/pipeline_options.py#L229]
> skips an option if the option value is {{{}False{}}}. For example,
> {{use_public_ips=False}} is ignored and the Dataflow job will run with public
> IPs. To disable public IPs, the option dictionary must use
> {{no_use_public_ips.}}
> This makes the user very confused, and sometimes the pipeline works in an
> unexpected way.
> We must have the consistent behavior between the two methods, or at least a
> warning about invalid ignored options.
> BEAM-9093 dealt with a similar issue for {{PipelineOptions()}}. Like the
> issue, I guess adding a warning in `PipelineOptions.from_dictionary()` for
> ignored options can help reducing the confusion, if we cannot have two
> methods have exactly the same behavior.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
