[
https://issues.apache.org/jira/browse/BEAM-13960?focusedWorklogId=732005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732005
]
ASF GitHub Bot logged work on BEAM-13960:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/22 23:52
Start Date: 23/Feb/22 23:52
Worklog Time Spent: 10m
Work Description: laraschmidt commented on a change in pull request
#16875:
URL: https://github.com/apache/beam/pull/16875#discussion_r813430056
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -579,6 +579,16 @@ public boolean isSupertypeOf(TypeName other) {
/** Convert the Java type used by the base {@link FieldType} to the input
type. */
@NonNull
InputT toInputType(@NonNull BaseT base);
+
+ /** Convert the Java type used by the base {@link FieldType} to the input
type. */
+ default BaseT toBaseTypeGeneric(Object input) {
+ return toBaseType((InputT) input);
+ }
+
+ /** Convert the Java type used by the base {@link FieldType} to the input
type. */
+ default InputT toInputTypeGeneric(Object base) {
+ return toInputType((BaseT) base);
+ }
Review comment:
Got something working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 732005)
Time Spent: 1h 20m (was: 1h 10m)
> SchemaTranslation.RowToProto does not properly handle all types
> ---------------------------------------------------------------
>
> Key: BEAM-13960
> URL: https://issues.apache.org/jira/browse/BEAM-13960
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Lara Schmidt
> Assignee: Lara Schmidt
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It doesn't properly handle logical types, nulls, datetime or decimal.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
