[
https://issues.apache.org/jira/browse/BEAM-13906?focusedWorklogId=732451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732451
]
ASF GitHub Bot logged work on BEAM-13906:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/22 16:15
Start Date: 24/Feb/22 16:15
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #16934:
URL: https://github.com/apache/beam/pull/16934#issuecomment-1050021154
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16934](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e0716ed) into
[master](https://codecov.io/gh/apache/beam/commit/60ea50f6b7fff7d482890b9006050b7ab4ac4157?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(60ea50f) will **decrease** coverage by `28.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16934 +/- ##
===========================================
- Coverage 74.69% 45.82% -28.87%
===========================================
Files 657 205 -452
Lines 82593 24227 -58366
===========================================
- Hits 61693 11103 -50590
+ Misses 19900 12129 -7771
+ Partials 1000 995 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `45.82% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/runtime/exec/emit.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9lbWl0Lmdv)
| `51.92% <0.00%> (-9.99%)` | :arrow_down: |
|
[sdks/go/pkg/beam/core/util/protox/any.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcHJvdG94L2FueS5nbw==)
| `46.93% <0.00%> (-9.16%)` | :arrow_down: |
|
[sdks/go/pkg/beam/provision/provision.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9wcm92aXNpb24vcHJvdmlzaW9uLmdv)
| `27.50% <0.00%> (-7.99%)` | :arrow_down: |
|
[sdks/go/pkg/beam/flatten.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9mbGF0dGVuLmdv)
| `44.44% <0.00%> (-7.94%)` | :arrow_down: |
|
[sdks/go/pkg/beam/validate.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS92YWxpZGF0ZS5nbw==)
| `42.10% <0.00%> (-7.90%)` | :arrow_down: |
|
[sdks/go/pkg/beam/core/graph/coder/int.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL2ludC5nbw==)
| `70.00% <0.00%> (-7.78%)` | :arrow_down: |
|
[sdks/go/pkg/beam/core/graph/coder/time.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3RpbWUuZ28=)
| `70.00% <0.00%> (-7.78%)` | :arrow_down: |
|
[sdks/go/pkg/beam/core/graph/coder/stringutf8.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3N0cmluZ3V0ZjguZ28=)
| `65.90% <0.00%> (-7.78%)` | :arrow_down: |
|
[sdks/go/pkg/beam/combine.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb21iaW5lLmdv)
| `39.53% <0.00%> (-7.69%)` | :arrow_down: |
|
[sdks/go/pkg/beam/options/gcpopts/options.go](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL2djcG9wdHMvb3B0aW9ucy5nbw==)
| `62.06% <0.00%> (-7.50%)` | :arrow_down: |
| ... and [626
more](https://codecov.io/gh/apache/beam/pull/16934/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[60ea50f...e0716ed](https://codecov.io/gh/apache/beam/pull/16934?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 732451)
Time Spent: 20m (was: 10m)
> Add unit testing to the errors package
> --------------------------------------
>
> Key: BEAM-13906
> URL: https://issues.apache.org/jira/browse/BEAM-13906
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Labels: starter
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [internal errors
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/internal/errors]
> We want code coverage at or above 50%, it is currently at 39.5%.
> There are a number of tests already present for this package, most of this
> task is finding the gaps in code coverage and writing test cases for them.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
