[
https://issues.apache.org/jira/browse/BEAM-13886?focusedWorklogId=732486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732486
]
ASF GitHub Bot logged work on BEAM-13886:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/22 16:54
Start Date: 24/Feb/22 16:54
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16935:
URL: https://github.com/apache/beam/pull/16935#issuecomment-1050052726
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16935](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5c032ad) into
[master](https://codecov.io/gh/apache/beam/commit/2a45a5b6c34141dcc595c5cda3d28264e542bdff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2a45a5b) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16935 +/- ##
==========================================
- Coverage 73.00% 73.00% -0.01%
==========================================
Files 658 659 +1
Lines 86706 86772 +66
==========================================
+ Hits 63301 63344 +43
- Misses 22405 22425 +20
- Partials 1000 1003 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `45.71% <0.00%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...s/go/pkg/beam/core/graph/window/trigger/trigger.go](https://codecov.io/gh/apache/beam/pull/16935/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL3dpbmRvdy90cmlnZ2VyL3RyaWdnZXIuZ28=)
| `65.15% <0.00%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[2a45a5b...5c032ad](https://codecov.io/gh/apache/beam/pull/16935?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 732486)
Time Spent: 0.5h (was: 20m)
> Add unit testing to the trigger package
> ---------------------------------------
>
> Key: BEAM-13886
> URL: https://issues.apache.org/jira/browse/BEAM-13886
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Ritesh Ghorse
> Priority: P2
> Labels: starter
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add basic unit testing to the [trigger
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/core/graph/window/trigger]
> We want code coverage at or above 50%, it is currently at 0%.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
