[
https://issues.apache.org/jira/browse/BEAM-5381?focusedWorklogId=223810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223810
]
ASF GitHub Bot logged work on BEAM-5381:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/19 20:14
Start Date: 05/Apr/19 20:14
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8238: [BEAM-5381]
Fix duplicate nodes ID for CoGBKs with Scopes.
URL: https://github.com/apache/beam/pull/8238
* Wrong id was returned for CoGBK expansions, so the expanded transform
didn't end up in the subtransform of the parent Scope.
* CoGBK inject node outputs need to include edge name as well, not just
input node name, otherwise there's an output name collision (caught by Flink
runner's consistency check).
Originally in https://github.com/apache/beam/pull/7889, but includes an
update to the an integration test to prevent regression.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223810)
Time Spent: 1h 10m (was: 1h)
> Dataflow runner creates duplicate CoGBK step IDs
> ------------------------------------------------
>
> Key: BEAM-5381
> URL: https://issues.apache.org/jira/browse/BEAM-5381
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Cody Schroeder
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://gist.github.com/schroederc/699f42e407702cf9584b15d6885ad297
> If the attached {{beam_dataflow_err.go}} pipeline is executed with the
> {{dataflow}} runner, GCP reports the following error:
> {code}
> Step with name e5 already exists. Duplicates are not allowed.
> {code}
> Executing the pipeline in {{--dry_run}} mode shows that "e5" is indeed
> duplicated. If the CoGBK in the pipeline is not scoped, the duplication is
> fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
