[
https://issues.apache.org/jira/browse/BEAM-13866?focusedWorklogId=732721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732721
]
ASF GitHub Bot logged work on BEAM-13866:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/22 22:01
Start Date: 24/Feb/22 22:01
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #16943:
URL: https://github.com/apache/beam/pull/16943#issuecomment-1050307154
> There are a lot of things that just wind up being mutex-guarded wrappers
around other types and not doing much else, which is fine so long as we trust
that golang mutexes actually work correctly. It just also makes test cases
around these things unnecessary or, in this case, extremely simple. Eventually
I'd like to not have stuff like this kicking around but for the time being it's
here
+1 This is a simple enough usage, we don't need to also test the mutex. If
things were a few degrees removed, and we were wrangling multiple goroutines,
we'd be testing scenarios like this wrapper intends to ensure. Eg - complicated
situation, but we have multiple errors, ensure the first error which we know by
construction is returned.
This package, like stringx is largely a bit of premature optimization, since
it's very easy to implement in place. But we do actually use this one IIRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 732721)
Time Spent: 1h 20m (was: 1h 10m)
> Improve Code Coverage of the Go SDK
> -----------------------------------
>
> Key: BEAM-13866
> URL: https://issues.apache.org/jira/browse/BEAM-13866
> Project: Beam
> Issue Type: Task
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Since code coverage checking and tracking was added to the Go SDK, it has sat
> under 45% total code coverage (looking solely at unit testing.) This is a
> tracking ticket for efforts to improve code coverage for individual packages
> under 50% coverage and increase total code coverage.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
