[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=732891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732891
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/22 07:12
Start Date: 25/Feb/22 07:12
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #16846:
URL: https://github.com/apache/beam/pull/16846#discussion_r814525377
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -151,6 +177,10 @@ private static SpannerAccessor
createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
+ if (spannerConfig.getIsLocalChannelProvider() != null
+ && spannerConfig.getIsLocalChannelProvider().get()) {
+
builder.setChannelProvider(LocalChannelProvider.create(emulatorHost.get()));
Review comment:
is there any chance of passing the LocalChannelProvider from the test to
avoid depending on gax_grpc_test in the main package? It's not mandatory, but
it would make life easier for like 1% of users, who, may have version clashes
with that at some point : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 732891)
Time Spent: 27h 20m (was: 27h 10m)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Assignee: Thiago Nunes
> Priority: P2
> Fix For: 2.37.0
>
> Time Spent: 27h 20m
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
