[
https://issues.apache.org/jira/browse/BEAM-13910?focusedWorklogId=733066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733066
]
ASF GitHub Bot logged work on BEAM-13910:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/22 14:25
Start Date: 25/Feb/22 14:25
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16942:
URL: https://github.com/apache/beam/pull/16942#issuecomment-1050267114
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16942](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2e01238) into
[master](https://codecov.io/gh/apache/beam/commit/cc16171bfa5502b56931798d62e522014fa03e94?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(cc16171) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16942 +/- ##
==========================================
+ Coverage 73.00% 73.06% +0.06%
==========================================
Files 658 660 +2
Lines 86706 86786 +80
==========================================
+ Hits 63301 63412 +111
+ Misses 22405 22372 -33
- Partials 1000 1002 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `45.96% <ø> (+0.30%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...s/go/pkg/beam/core/graph/window/trigger/trigger.go](https://codecov.io/gh/apache/beam/pull/16942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL3dpbmRvdy90cmlnZ2VyL3RyaWdnZXIuZ28=)
| `59.09% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/util/errorx/guarded.go](https://codecov.io/gh/apache/beam/pull/16942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS91dGlsL2Vycm9yeC9ndWFyZGVkLmdv)
| `100.00% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/util/gcsx/gcs.go](https://codecov.io/gh/apache/beam/pull/16942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS91dGlsL2djc3gvZ2NzLmdv)
| `27.41% <0.00%> (+27.41%)` | :arrow_up: |
|
[sdks/go/pkg/beam/internal/errors/errors.go](https://codecov.io/gh/apache/beam/pull/16942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pbnRlcm5hbC9lcnJvcnMvZXJyb3JzLmdv)
| `87.50% <0.00%> (+42.70%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[cc16171...2e01238](https://codecov.io/gh/apache/beam/pull/16942?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733066)
Time Spent: 2h 10m (was: 2h)
> Add unit testing to the gcsx package
> ------------------------------------
>
> Key: BEAM-13910
> URL: https://issues.apache.org/jira/browse/BEAM-13910
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Labels: starter
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Add unit testing to the [gcsx
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/util/gcsx]
> We want code coverage at or above 50%, it is currently at 0%.
> Helper functions can be tested easily, main functionality requires mocking
> GCS interactions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
