[
https://issues.apache.org/jira/browse/BEAM-14005?focusedWorklogId=733540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733540
]
ASF GitHub Bot logged work on BEAM-14005:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/22 21:05
Start Date: 26/Feb/22 21:05
Worklog Time Spent: 10m
Work Description: nielm commented on a change in pull request #16960:
URL: https://github.com/apache/beam/pull/16960#discussion_r815353923
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java
##########
@@ -373,19 +379,12 @@ public void testReadMetrics() throws Exception {
any(ReadQueryUpdateTransactionOption.class)))
.thenReturn(Arrays.asList(fakePartition, fakePartition,
fakePartition));
when(mockBatchTx.execute(any(Partition.class)))
- .thenThrow(
Review comment:
Added and renamed tests:
testQueryMetricsFail()
testQueryMetricsSucceed()
testReadMetricsFail()
testReadMetricsSucceed()
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java
##########
@@ -373,19 +379,12 @@ public void testReadMetrics() throws Exception {
any(ReadQueryUpdateTransactionOption.class)))
.thenReturn(Arrays.asList(fakePartition, fakePartition,
fakePartition));
when(mockBatchTx.execute(any(Partition.class)))
- .thenThrow(
Review comment:
This is the original code - this PR removes the failures from this test
so that it succeeds.
In fact there should be 4 tests - failure/success on query/read - working on
that now
Ugh, This entire file is a mess - I will refactor in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733540)
Time Spent: 1.5h (was: 1h 20m)
> Exceptions when reading from Spanner ignored
> --------------------------------------------
>
> Key: BEAM-14005
> URL: https://issues.apache.org/jira/browse/BEAM-14005
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Affects Versions: 2.34.0, 2.35.0, 2.36.0, 2.37.0
> Reporter: Niel Markwick
> Assignee: Niel Markwick
> Priority: P1
> Labels: cloud-spanner, regression
> Fix For: 2.37.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Regression from BEAM-11982:
> [BatchSpannerRead.java#L223|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java#L223]
> will ignore exceptions raised when reading from spanner. It will log an
> metric and continue.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
