[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=733685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733685
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 03:20
Start Date: 28/Feb/22 03:20
Worklog Time Spent: 10m
Work Description: thiagotnunes commented on a change in pull request
#16844:
URL: https://github.com/apache/beam/pull/16844#discussion_r815425215
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -430,14 +433,10 @@ public static Write write() {
public static ReadChangeStream readChangeStream() {
return new AutoValue_SpannerIO_ReadChangeStream.Builder()
.setSpannerConfig(SpannerConfig.create())
Review comment:
Extracts defaults to constants
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -706,6 +706,7 @@ class BeamModulePlugin implements Plugin<Project> {
woodstox_core_asl :
"org.codehaus.woodstox:woodstox-core-asl:4.4.1",
zstd_jni :
"com.github.luben:zstd-jni:1.5.2-1",
quickcheck_core :
"com.pholser:junit-quickcheck-core:$quickcheck_version",
+ quickcheck_generators :
"com.pholser:junit-quickcheck-generators:$quickcheck_version",
Review comment:
Adds quickcheck generators for property based testing
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/model/PartitionMetadata.java
##########
@@ -66,8 +66,6 @@
@AvroEncode(using = TimestampEncoding.class)
private Timestamp startTimestamp;
- @Nullable
- @org.apache.avro.reflect.Nullable
Review comment:
Not nullable anymore, as we always provide a default (if null was given
as an input it this variable = `Timestamp.MAX - 1ns`)
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -1474,6 +1473,13 @@ public ReadChangeStream
withTraceSampleProbability(Double probability) {
checkArgument(
getInclusiveStartAt() != null,
"SpannerIO.readChangeStream() requires the start time to be set.");
Review comment:
Checks if the end timestamp is within bounds `Timestamp.MAX - 1ns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733685)
Time Spent: 30h 10m (was: 30h)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Assignee: Thiago Nunes
> Priority: P2
> Fix For: 2.37.0
>
> Time Spent: 30h 10m
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
