[
https://issues.apache.org/jira/browse/BEAM-13872?focusedWorklogId=733759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733759
]
ASF GitHub Bot logged work on BEAM-13872:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 08:00
Start Date: 28/Feb/22 08:00
Worklog Time Spent: 10m
Work Description: pavel-avilov commented on a change in pull request
#16891:
URL: https://github.com/apache/beam/pull/16891#discussion_r815651855
##########
File path: playground/backend/internal/code_processing/code_processing_test.go
##########
@@ -962,36 +1096,78 @@ func Test_runStep(t *testing.T) {
pipelineOptions string
pipelineLifeCycleCtx context.Context
cancelChannel chan bool
+ createExecFile bool
}
tests := []struct {
- name string
- args args
- code string
+ name string
+ args args
+ code string
+ expectedStatus pb.Status
}{
{
- name: "Test run step working without an error",
+ name: "Test run step working on python sdk",
args: args{
ctx: context.Background(),
cacheService: cacheService,
- pipelineId: uuid.UUID{},
+ pipelineId: uuid.New(),
isUnitTest: false,
- sdkEnv: sdkEnv,
+ sdkEnv: sdkPythonEnv,
+ pipelineOptions: "",
+ pipelineLifeCycleCtx: context.Background(),
+ cancelChannel: make(chan bool, 1),
+ createExecFile: true,
+ },
+ code: helloWordPython,
+ expectedStatus: pb.Status_STATUS_RUN_ERROR,
+ },
+ {
+ name: "Test run step working on go sdk",
+ args: args{
+ ctx: context.Background(),
+ cacheService: cacheService,
+ pipelineId: uuid.New(),
+ isUnitTest: true,
+ sdkEnv: sdkGoEnv,
+ pipelineOptions: "",
+ pipelineLifeCycleCtx: context.Background(),
+ cancelChannel: make(chan bool, 1),
+ createExecFile: true,
+ },
+ code: helloWordGo,
+ expectedStatus: pb.Status_STATUS_RUN_ERROR,
+ },
+ {
+ name: "Test run step without preparing files with code",
Review comment:
Fail, expected to get `Status_STATUS_RUN_ERROR` pipeline status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733759)
Time Spent: 2h 20m (was: 2h 10m)
> [Playground] Increase test coverage for the code_processing package
> -------------------------------------------------------------------
>
> Key: BEAM-13872
> URL: https://issues.apache.org/jira/browse/BEAM-13872
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Pavel Avilov
> Priority: P3
> Labels: beam-playground-backend
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Need to add unit tests to increase test coverage for the _code_processing_
> package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
