[
https://issues.apache.org/jira/browse/BEAM-6769?focusedWorklogId=223970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223970
]
ASF GitHub Bot logged work on BEAM-6769:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/19 00:56
Start Date: 06/Apr/19 00:56
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8047: [BEAM-6769]
write bytes to bigquery in python 2
URL: https://github.com/apache/beam/pull/8047#discussion_r272777024
##########
File path: sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py
##########
@@ -115,8 +117,11 @@ def _setup_new_types_env(self):
table_data = [
{'bytes':b'xyw=', 'date':'2011-01-01', 'time':'23:59:59.999999'},
{'bytes':b'abc=', 'date':'2000-01-01', 'time':'00:00:00'},
- {'bytes':b'dec=', 'date':'3000-12-31', 'time':'23:59:59.990000'}
+ {'bytes':b'dec=', 'date':'3000-12-31', 'time':'23:59:59.990000'},
+ {'bytes':b'\xab\xac\xad', 'date':'2000-01-01', 'time':'00:00:00'}
]
+ for row in table_data:
Review comment:
Let's add a comment here that a bigquery client requires the user to
base64-encode bytes sequences before passing them to BQ. If you have a link
handy, please include it.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 223970)
Time Spent: 4h (was: 3h 50m)
> BigQuery IO does not support bytes in Python 3
> ----------------------------------------------
>
> Key: BEAM-6769
> URL: https://issues.apache.org/jira/browse/BEAM-6769
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Juta Staes
> Assignee: Juta Staes
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> In Python 2 you could write bytes data to BigQuery. This is tested in
>
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py#L186]
> Python 3 does not support
> {noformat}
> json.dumps({'test': b'test'}){noformat}
> which is used to encode the data in
>
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery_tools.py#L959]
>
> How should writing bytes to BigQuery be handled in Python 3?
> * Forbid writing bytes into BigQuery on Python 3
> * Guess the encoding (utf-8?)
> * Pass the encoding to BigQuery
> cc: [~tvalentyn]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
