[
https://issues.apache.org/jira/browse/BEAM-13416?focusedWorklogId=734098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734098
]
ASF GitHub Bot logged work on BEAM-13416:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 18:54
Start Date: 28/Feb/22 18:54
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #16947:
URL: https://github.com/apache/beam/pull/16947#issuecomment-1054562729
JavaFieldSchema should work for immutable objects with builders too. Can we
elucidate what the gap is there?
JavaFieldSchema is fairly optimized using bytecode generation, so it
doesn't have to convert back and forth to a Row object (rather the Row
object simply forwards it accesses to direct accesses of the POJO using
bytecode). If we are able to leverage that, it will be a
significant performance advantage over the SdkPojo schema provider.
On Mon, Feb 28, 2022 at 10:49 AM Moritz Mack ***@***.***>
wrote:
> @reuvenlax <https://github.com/reuvenlax> JavaFieldSchema doesn't work
> for AWS models, the sdk v2 uses immutable objects based on builders / final
> fields. SdkPojo is the common interface of all of these models.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/16947#issuecomment-1054559282>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVKQRE7ZTS7RTWNVHJ3U5O7UFANCNFSM5PKC75YA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
>
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
>
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 734098)
Time Spent: 1h 10m (was: 1h)
> SqsIO.write input / construction of Sqs request
> -----------------------------------------------
>
> Key: BEAM-13416
> URL: https://issues.apache.org/jira/browse/BEAM-13416
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: Moritz Mack
> Priority: P2
> Labels: aws, aws-sdk-v2, sqs
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> SqsIO.write should support arbitrary types T and be implemented in terms of a
> mapper function that converts T into an AWS request.
> The current implementation of write as
> {{PTransform<PCollection<SendMessageRequest>, PDone>}} is a rather poor
> choice. It may requires an additional unnecessary serialization &
> deserialisation round. But even worse, the current
> {{SendMessageRequestCoder}} does not support any advanced configuration
> beyond queueUrl and messageBody and will silently drop it without even
> warning the user.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
