[
https://issues.apache.org/jira/browse/BEAM-13980?focusedWorklogId=734123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734123
]
ASF GitHub Bot logged work on BEAM-13980:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 19:26
Start Date: 28/Feb/22 19:26
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16967:
URL: https://github.com/apache/beam/pull/16967#issuecomment-1054567740
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16967](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(4e736e3) into
[release-2.37.0](https://codecov.io/gh/apache/beam/commit/39895d1ea6a0cbf94bbaecde67e952213cbf4708?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(39895d1) will **increase** coverage by `36.82%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## release-2.37.0 #16967 +/- ##
===================================================
+ Coverage 46.79% 83.61% +36.82%
===================================================
Files 203 452 +249
Lines 20044 62277 +42233
===================================================
+ Hits 9379 52072 +42693
- Misses 9665 10205 +540
+ Partials 1000 0 -1000
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...thon/apache\_beam/io/aws/clients/s3/boto3\_client.py](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvYm90bzNfY2xpZW50LnB5)
| `14.39% <12.50%> (ø)` | |
|
[sdks/go/pkg/beam/core/graph/fn.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2ZuLmdv)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/iterable.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL2l0ZXJhYmxlLmdv)
| | |
|
[sdks/go/pkg/beam/validate.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS92YWxpZGF0ZS5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/harness/datamgr.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9kYXRhbWdyLmdv)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/double.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL2RvdWJsZS5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/graphx/coder.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L2NvZGVyLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/translate.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy90cmFuc2xhdGUuZ28=)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/windows.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3dpbmRvd3MuZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/harness/session.go](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zZXNzaW9uLmdv)
| | |
| ... and [646
more](https://codecov.io/gh/apache/beam/pull/16967/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[39895d1...4e736e3](https://codecov.io/gh/apache/beam/pull/16967?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 734123)
Time Spent: 4h 40m (was: 4.5h)
> S3 Client broken: missing get_object_metadata()
> -----------------------------------------------
>
> Key: BEAM-13980
> URL: https://issues.apache.org/jira/browse/BEAM-13980
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.36.0, 2.37.0
> Reporter: Janek Bevendorff
> Assignee: Janek Bevendorff
> Priority: P1
> Fix For: 2.38.0
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Since 2.36.0, the Boto3 S3 client is broken, because the
> get_object_metadata() method is missing. Something must have gone wrong
> during the merge of
> [BEAM-13585|https://issues.apache.org/jira/browse/BEAM-13585] that function
> should not have been deleted. The total lack of tests for this whole class is
> definitely a problem.
> I prepared a PR that re-adds the missing method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
