[
https://issues.apache.org/jira/browse/BEAM-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny McCormick updated BEAM-14012:
-----------------------------------
Description:
Right now, we occasionally notice that checked in files have not been formatted
properly (e.g. [https://github.com/apache/beam/pull/16973).] It would be nice
to catch these as a precommit check (it could be something as simple as a quick
Actions or Jira job that runs:
```
go fmt sdks/go/...
git diff-index --quiet HEAD – || (echo "Run go fmt before checking in changes"
&& exit 1)}}
{{```}}
That way we push the work to the original authors and let robots enforce
linting :)
was:
Right now, we occasionally notice that checked in files have not been formatted
properly (e.g. [https://github.com/apache/beam/pull/16973).] It would be nice
to catch these as a precommit check (it could be something as simple as a quick
Actions or Jira job that runs:
```
{{go fmt sdks/go/...
git diff-index --quiet HEAD – || (echo "Run go fmt before checking in changes"
&& exit 1)}}
{{```}}
That way we push the work to the original authors and let robots enforce
linting :)
> Add go fmt CI check
> -------------------
>
> Key: BEAM-14012
> URL: https://issues.apache.org/jira/browse/BEAM-14012
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Danny McCormick
> Priority: P2
>
> Right now, we occasionally notice that checked in files have not been
> formatted properly (e.g. [https://github.com/apache/beam/pull/16973).] It
> would be nice to catch these as a precommit check (it could be something as
> simple as a quick Actions or Jira job that runs:
> ```
> go fmt sdks/go/...
> git diff-index --quiet HEAD – || (echo "Run go fmt before checking in
> changes" && exit 1)}}
> {{```}}
> That way we push the work to the original authors and let robots enforce
> linting :)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
