[
https://issues.apache.org/jira/browse/BEAM-13974?focusedWorklogId=734245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734245
]
ASF GitHub Bot logged work on BEAM-13974:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 23:20
Start Date: 28/Feb/22 23:20
Worklog Time Spent: 10m
Work Description: yirutang commented on a change in pull request #16906:
URL: https://github.com/apache/beam/pull/16906#discussion_r816327095
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java
##########
@@ -466,24 +495,48 @@ public String toString() {
java.time.Duration timeElapsed = java.time.Duration.between(now,
Instant.now());
appendLatencyDistribution.update(timeElapsed.toMillis());
+ idleTimer
+ .offset(streamIdleTime)
+ .withOutputTimestamp(BoundedWindow.TIMESTAMP_MAX_VALUE)
+ .setRelative();
}
- @OnWindowExpiration
- public void onWindowExpiration(
+ // called by the idleTimer and window-expiration handlers.
+ private void finalizeStream(
Review comment:
Sorry didn't send it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 734245)
Time Spent: 1h 20m (was: 1h 10m)
> Idle streams in BiQuery Storage API
> -----------------------------------
>
> Key: BEAM-13974
> URL: https://issues.apache.org/jira/browse/BEAM-13974
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
