[
https://issues.apache.org/jira/browse/BEAM-13051?focusedWorklogId=735512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735512
]
ASF GitHub Bot logged work on BEAM-13051:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/22 19:29
Start Date: 02/Mar/22 19:29
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16562:
URL: https://github.com/apache/beam/pull/16562#issuecomment-1016616248
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16562](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f8428d2) into
[master](https://codecov.io/gh/apache/beam/commit/a589b103a6b06e4146c96baed73643c28a8605e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a589b10) will **increase** coverage by `37.18%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head f8428d2 differs from pull request most recent
head 523e0d0. Consider uploading reports for the commit 523e0d0 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16562 +/- ##
===========================================
+ Coverage 46.43% 83.61% +37.18%
===========================================
Files 201 453 +252
Lines 19787 62478 +42691
===========================================
+ Hits 9189 52244 +43055
- Misses 9612 10234 +622
+ Partials 986 0 -986
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.61% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/filesystem.py](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbS5weQ==)
| `89.41% <100.00%> (ø)` | |
|
[...beam/testing/load\_tests/load\_test\_metrics\_utils.py](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9sb2FkX3Rlc3RzL2xvYWRfdGVzdF9tZXRyaWNzX3V0aWxzLnB5)
| `34.71% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/transforms/stats/min\_switch.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL3N0YXRzL21pbl9zd2l0Y2guZ28=)
| | |
|
[...ks/go/pkg/beam/core/runtime/harness/cache\_hooks.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9jYWNoZV9ob29rcy5nbw==)
| | |
|
[sdks/go/pkg/beam/io/filesystem/util.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL3V0aWwuZ28=)
| | |
|
[sdks/go/pkg/beam/core/util/reflectx/functions.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvZnVuY3Rpb25zLmdv)
| | |
|
[sdks/go/pkg/beam/core/util/reflectx/structs.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvc3RydWN0cy5nbw==)
| | |
|
[sdks/go/pkg/beam/core/graph/fn.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2ZuLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/genx/genx.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ2VueC9nZW54Lmdv)
| | |
|
[sdks/go/pkg/beam/runners/direct/gbk.go](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RpcmVjdC9nYmsuZ28=)
| | |
| ... and [646
more](https://codecov.io/gh/apache/beam/pull/16562/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a589b10...523e0d0](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735512)
Time Spent: 28.5h (was: 28h 20m)
> Enable all practical pylint warnings
> ------------------------------------
>
> Key: BEAM-13051
> URL: https://issues.apache.org/jira/browse/BEAM-13051
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P2
> Time Spent: 28.5h
> Remaining Estimate: 0h
>
> We currently have 75 pylint checks disabled globally:
> https://github.com/apache/beam/blob/0863d95205410567a7ab191fd0a46308a0d54bb7/sdks/python/.pylintrc#L81
> I think some of these are impractical for Beam (e.g.
> [super-init-not-called|https://pycodequ.al/docs/pylint-messages/w0231-super-init-not-called.html]
> because of BEAM-6158), but most of them are verifying good conventions that
> we should try to stick to. Let's enable as many of the checks as possible,
> such that the only disabled checks are really impractical for Beam, or are
> incompatible with the Beam community's coding style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
