[
https://issues.apache.org/jira/browse/BEAM-13903?focusedWorklogId=735517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735517
]
ASF GitHub Bot logged work on BEAM-13903:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/22 19:40
Start Date: 02/Mar/22 19:40
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #16994:
URL: https://github.com/apache/beam/pull/16994#issuecomment-1057307597
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16994](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(8517ff3) into
[master](https://codecov.io/gh/apache/beam/commit/3cd1f7f949bd476abb11bdb0b368a2f12a496cd1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(3cd1f7f) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16994 +/- ##
==========================================
+ Coverage 73.80% 73.84% +0.04%
==========================================
Files 663 663
Lines 87056 87056
==========================================
+ Hits 64251 64287 +36
+ Misses 21721 21681 -40
- Partials 1084 1088 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `48.95% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/runtime/metricsx/urns.go](https://codecov.io/gh/apache/beam/pull/16994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvbWV0cmljc3gvdXJucy5nbw==)
| `39.18% <0.00%> (+13.51%)` | :arrow_up: |
|
[sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go](https://codecov.io/gh/apache/beam/pull/16994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvbWV0cmljc3gvbWV0cmljc3guZ28=)
| `58.86% <0.00%> (+18.43%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[3cd1f7f...8517ff3](https://codecov.io/gh/apache/beam/pull/16994?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735517)
Time Spent: 20m (was: 10m)
> Increase unit testing in the metricsx pacakge
> ---------------------------------------------
>
> Key: BEAM-13903
> URL: https://issues.apache.org/jira/browse/BEAM-13903
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Labels: starter
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [metricsx
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/core/runtime/metricsx]
> We want code coverage at or above 50%, it is currently at 47.2%.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
