[
https://issues.apache.org/jira/browse/BEAM-14022?focusedWorklogId=735663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735663
]
ASF GitHub Bot logged work on BEAM-14022:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/22 23:47
Start Date: 02/Mar/22 23:47
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16940:
URL: https://github.com/apache/beam/pull/16940#discussion_r818007894
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java
##########
@@ -67,10 +68,13 @@
private static final String URN_BEAM_LOGICAL_JAVASDK =
"beam:logical_type:javasdk:v1";
// TODO(BEAM-7855): Populate this with a LogicalTypeRegistrar, which
includes a way to construct
- // the LogicalType
- // given an argument.
+ // the LogicalType given an argument.
private static final ImmutableMap<String, Class<? extends LogicalType<?, ?>>>
- STANDARD_LOGICAL_TYPES = ImmutableMap.of(MicrosInstant.IDENTIFIER,
MicrosInstant.class);
+ STANDARD_LOGICAL_TYPES =
+ ImmutableMap.<String, Class<? extends LogicalType<?, ?>>>builder()
+ .put(MicrosInstant.IDENTIFIER, MicrosInstant.class)
+ .put(SchemaLogicalType.IDENTIFIER, SchemaLogicalType.class)
Review comment:
Please also document this in beam_runner_api.proto:
https://github.com/apache/beam/blob/75c25f0d609372b8daffc1365277c6e69fd6f96a/model/pipeline/src/main/proto/beam_runner_api.proto#L1053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735663)
Time Spent: 20m (was: 10m)
> Add Schema logical type
> -----------------------
>
> Key: BEAM-14022
> URL: https://issues.apache.org/jira/browse/BEAM-14022
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Lara Schmidt
> Assignee: Lara Schmidt
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add a schema logical type that is itself a schema. The base type can be bytes
> and proto serialization can be used to convert to and from that type.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
