[
https://issues.apache.org/jira/browse/BEAM-13925?focusedWorklogId=736139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736139
]
ASF GitHub Bot logged work on BEAM-13925:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/22 16:42
Start Date: 03/Mar/22 16:42
Worklog Time Spent: 10m
Work Description: damccorm opened a new pull request #17001:
URL: https://github.com/apache/beam/pull/17001
Right now, we don't have a well defined automated system for staying on top
of pull request reviews - we rely on contributors being able to find the
correct OWNERS file and committers manually triaging/calling attention to old
pull requests. This is the continuation of an effort to improve our automation
around this. [Design doc for the full effort
here](https://docs.google.com/document/d/1FhRPRD6VXkYlLAPhNfZB7y2Yese2FCWBzjx67d3TjBo/edit#).
This specific change adds automation to flag prs that should be receiving
attention but aren't. There are basically 3 parts:
1) Find prs that are assigned to a reviewer and haven't had action in 7 days
- tag the reviewers and add a slow-review label.
2) Find prs with the slow-review label that haven't had action in 2
additional business days - assign a new set of **committers**
3) Remove the slow-review label any time a reviewer performs a review or
comments on the pr.
This was tested in my test repo here -
https://github.com/damccorm/beam-pr-bot-demo. I lowered the time thresholds so
I didn't have to wait for a PR to sit for days to test it. The only eligible PR
for the automation was initially
https://github.com/damccorm/beam-pr-bot-demo/pull/4, so that's where most of
the testing happened. There's a lot of junk in between the start and finish as
I was getting things working, but the last couple comments show it working. The
other prs show that they get excluded correctly (either because they've had
notifications silenced or they have not had reviewers assigned by the bot for
other reasons.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 736139)
Time Spent: 9h 20m (was: 9h 10m)
> Automate Reviewer Assignment
> ----------------------------
>
> Key: BEAM-13925
> URL: https://issues.apache.org/jira/browse/BEAM-13925
> Project: Beam
> Issue Type: Improvement
> Components: beam-community
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> Right now, we don't have a well defined automated system for staying on top
> of pull request reviews - we rely on contributors being able to find the
> correct OWNERS file and committers manually triaging/calling attention to old
> pull requests. We should add automation driven by GitHub Actions to
> automatically round robin new PR reviews to a set of contributors, thus
> balancing the load.
>
> Design doc here -
> https://docs.google.com/document/d/1FhRPRD6VXkYlLAPhNfZB7y2Yese2FCWBzjx67d3TjBo/edit#
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
