[ 
https://issues.apache.org/jira/browse/BEAM-14011?focusedWorklogId=736210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736210
 ]

ASF GitHub Bot logged work on BEAM-14011:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Mar/22 18:38
            Start Date: 03/Mar/22 18:38
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #16987:
URL: https://github.com/apache/beam/pull/16987#issuecomment-1058159732


   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#16987](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f209267) into 
[master](https://codecov.io/gh/apache/beam/commit/06e7c201dbdd8fe37d308b0bad2b1684e85e1dc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (06e7c20) will **decrease** coverage by `0.02%`.
   > The diff coverage is `75.86%`.
   
   > :exclamation: Current head f209267 differs from pull request most recent 
head 45c8464. Consider uploading reports for the commit 45c8464 to get more 
accurate results
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/16987/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #16987      +/-   ##
   ==========================================
   - Coverage   73.83%   73.80%   -0.03%     
   ==========================================
     Files         664      663       -1     
     Lines       87272    87136     -136     
   ==========================================
   - Hits        64434    64314     -120     
   - Misses      21735    21738       +3     
   + Partials     1103     1084      -19     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.63% <82.79%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...beam/testing/load\_tests/load\_test\_metrics\_utils.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9sb2FkX3Rlc3RzL2xvYWRfdGVzdF9tZXRyaWNzX3V0aWxzLnB5)
 | `34.45% <40.00%> (ø)` | |
   | 
[...kg/beam/core/runtime/xlangx/expansionx/download.go](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUveGxhbmd4L2V4cGFuc2lvbngvZG93bmxvYWQuZ28=)
 | `60.37% <47.82%> (-1.17%)` | :arrow_down: |
   | 
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
 | `92.02% <77.77%> (ø)` | |
   | 
[...s/interactive/dataproc/dataproc\_cluster\_manager.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kYXRhcHJvYy9kYXRhcHJvY19jbHVzdGVyX21hbmFnZXIucHk=)
 | `88.57% <85.13%> (ø)` | |
   | 
[sdks/python/apache\_beam/io/filesystem.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbS5weQ==)
 | `89.41% <100.00%> (ø)` | |
   | 
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
 | `81.39% <100.00%> (ø)` | |
   | 
[sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvbWV0cmljc3gvbWV0cmljc3guZ28=)
 | `40.42% <0.00%> (-18.44%)` | :arrow_down: |
   | 
[sdks/go/pkg/beam/core/runtime/metricsx/urns.go](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvbWV0cmljc3gvdXJucy5nbw==)
 | `25.67% <0.00%> (-13.52%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=)
 | `96.46% <0.00%> (-0.55%)` | :arrow_down: |
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
 | `93.14% <0.00%> (-0.50%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/beam/pull/16987/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[06e7c20...45c8464](https://codecov.io/gh/apache/beam/pull/16987?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 736210)
    Time Spent: 3.5h  (was: 3h 20m)

> AWS SDK2 S3FileSystem MultiPart Copy sets incorrect request parameters
> ----------------------------------------------------------------------
>
>                 Key: BEAM-14011
>                 URL: https://issues.apache.org/jira/browse/BEAM-14011
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-aws
>    Affects Versions: 2.29.0, 2.30.0, 2.31.0, 2.32.0, 2.33.0, 2.34.0, 2.35.0, 
> 2.36.0
>            Reporter: Stephen Patel
>            Assignee: Stephen Patel
>            Priority: P2
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> The following code locations use incorrect parameters:
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L518-L519]
>  and 
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L539-L540]
>  specifies the sourcePath instead of the destinationPath.
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L541]
>  specifies destinationPath.getBucket() instead of sourcePath.getBucket()
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L556]
>  specifies a constant part number of 1, instead of using the partNumber 
> variable.
> Taken together, these issues cause multipart copies to fail due to:
> {noformat}
> software.amazon.awssdk.services.s3.model.NoSuchUploadException: The specified 
> upload does not exist. The upload ID may be invalid, or the upload may have 
> been aborted or completed.
> {noformat}
> If the object references are fixes, the part number issue causes multipart 
> copies to fail due to:
> {noformat}
> software.amazon.awssdk.services.s3.model.S3Exception: The list of parts was 
> not in ascending order. Parts must be ordered by part number. 
> {noformat}
> Note: I checked the AWS SDK1 S3FileSystem and did not see the same issues.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to