[
https://issues.apache.org/jira/browse/BEAM-13947?focusedWorklogId=736304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736304
]
ASF GitHub Bot logged work on BEAM-13947:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/22 20:27
Start Date: 03/Mar/22 20:27
Worklog Time Spent: 10m
Work Description: yeandy commented on a change in pull request #16677:
URL: https://github.com/apache/beam/pull/16677#discussion_r819037873
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -4721,13 +4721,91 @@ def repeat(self, repeats):
pd.core.strings.StringMethods, 'get_dummies',
reason='non-deferred-columns')
- split = frame_base.wont_implement_method(
- pd.core.strings.StringMethods, 'split',
- reason='non-deferred-columns')
+ def _split_helper(
+ self, rsplit=False, pat=None, expand=False, regex=None, **kwargs):
+
+ # Adding arguments to kwargs. regex introduced in pandas 1.4
+ # but only for split, not rsplit
+ kwargs['pat'] = pat
+ kwargs['expand'] = expand
+ if PD_VERSION >= (1, 4) and not rsplit:
+ kwargs['regex'] = regex
Review comment:
I pushed a commit to incorporate all your suggestions, including one in
the above comment. But we can change that one back if stylistically, the
original is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 736304)
Time Spent: 6.5h (was: 6h 20m)
> Implement Series.str.split() and Series.str.rsplit() for DataFrame API
> ----------------------------------------------------------------------
>
> Key: BEAM-13947
> URL: https://issues.apache.org/jira/browse/BEAM-13947
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-dataframe, sdk-py-core
> Reporter: Andy Ye
> Assignee: Andy Ye
> Priority: P3
> Labels: dataframe-api
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
