[
https://issues.apache.org/jira/browse/BEAM-11085?focusedWorklogId=736379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736379
]
ASF GitHub Bot logged work on BEAM-11085:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/22 22:01
Start Date: 03/Mar/22 22:01
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #17007:
URL: https://github.com/apache/beam/pull/17007#issuecomment-1058535672
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17007?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17007](https://codecov.io/gh/apache/beam/pull/17007?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(93f453c) into
[master](https://codecov.io/gh/apache/beam/commit/d4663790e35ef98073df00ffc11cbaa205620401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(d466379) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/17007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17007 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 667 667
Lines 87340 87340
=======================================
Hits 64474 64474
Misses 21763 21763
Partials 1103 1103
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.02% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17007?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17007?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[d466379...93f453c](https://codecov.io/gh/apache/beam/pull/17007?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 736379)
Time Spent: 20m (was: 10m)
> [Go SDK] Windows are correctly observed in DoFns.
> -------------------------------------------------
>
> Key: BEAM-11085
> URL: https://issues.apache.org/jira/browse/BEAM-11085
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add a simple unit test to validate that user DoFns can observe windows.
> In particular add a Go unit test to the exec package, in the style of the
> ParDo execution unit test
> [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/pardo_test.go#L50]
>
> This requires writing a small but observable DoFn that observes windows, and
> configures inputs to achieve expected outputs for given window assignements.
> There may be a need to add a utility functions to configure the windows and
> event times in a FullValue conveniently for the test.
> Tests should cover single and multiple windows cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
