[
https://issues.apache.org/jira/browse/BEAM-14016?focusedWorklogId=736845&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736845
]
ASF GitHub Bot logged work on BEAM-14016:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/22 19:07
Start Date: 04/Mar/22 19:07
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#17009:
URL: https://github.com/apache/beam/pull/17009#discussion_r819835033
##########
File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py
##########
@@ -1247,14 +1253,17 @@ def process(self, element):
else:
raise ValueError("Unknown operation action: %s" % m.operation)
batch_func(**m.kwargs)
-
- self.service_metric.call('ok')
except (ClientError, GoogleAPICallError) as e:
- self.service_metric.call(str(e.code.value))
+ for service_metric in self.service_metrics.values():
+ service_metric.call(str(e.code.value))
Review comment:
Should we only be updating metrics for the tables that we tried to
update here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 736845)
Time Spent: 1.5h (was: 1h 20m)
>
> apache_beam.io.gcp.experimental.spannerio_write_it_test.SpannerWriteIntegrationTest.test_spanner_update
> fails in Python3.7 Postcommits
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-14016
> URL: https://issues.apache.org/jira/browse/BEAM-14016
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Valentyn Tymofieiev
> Assignee: Ning
> Priority: P1
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> For some reason only Python 3.7 suite is failing with this error.
> {noformat}
> > self)
> E
> apache_beam.runners.dataflow.dataflow_runner.DataflowRuntimeException:
> Dataflow pipeline failed. State: FAILED, Error:
> E Traceback (most recent call last):
> E File "apache_beam/runners/common.py", line 1198, in
> apache_beam.runners.common.DoFnRunner.process
> E File "apache_beam/runners/common.py", line 537, in
> apache_beam.runners.common.SimpleInvoker.invoke_process
> E File
> "/usr/local/lib/python3.7/site-packages/apache_beam/io/gcp/experimental/spannerio.py",
> line 1251, in process
> E self.service_metric.call('ok')
> E AttributeError: 'NoneType' object has no attribute 'call'
> E
> E During handling of the above exception, another exception occurred:
> E
> E Traceback (most recent call last):
> E File
> "/usr/local/lib/python3.7/site-packages/dataflow_worker/batchworker.py", line
> 646, in do_work
> E work_executor.execute()
> E File
> "/usr/local/lib/python3.7/site-packages/dataflow_worker/executor.py", line
> 210, in execute
> E op.finish()
> E File "apache_beam/runners/worker/operations.py", line 736, in
> apache_beam.runners.worker.operations.DoOperation.finish
> E File "apache_beam/runners/worker/operations.py", line 738, in
> apache_beam.runners.worker.operations.DoOperation.finish
> E File "apache_beam/runners/worker/operations.py", line 739, in
> apache_beam.runners.worker.operations.DoOperation.finish
> E File "apache_beam/runners/common.py", line 1253, in
> apache_beam.runners.common.DoFnRunner.finish
> E File "apache_beam/runners/common.py", line 1234, in
> apache_beam.runners.common.DoFnRunner._invoke_bundle_method
> E File "apache_beam/runners/common.py", line 1265, in
> apache_beam.runners.common.DoFnRunner._reraise_augmented
> E File "apache_beam/runners/common.py", line 1232, in
> apache_beam.runners.common.DoFnRunner._invoke_bundle_method
> E File "apache_beam/runners/common.py", line 475, in
> apache_beam.runners.common.DoFnInvoker.invoke_finish_bundle
> E File "apache_beam/runners/common.py", line 480, in
> apache_beam.runners.common.DoFnInvoker.invoke_finish_bundle
> E File "apache_beam/runners/common.py", line 1401, in
> apache_beam.runners.common._OutputProcessor.finish_bundle_outputs
> E File "apache_beam/runners/worker/operations.py", line 215, in
> apache_beam.runners.worker.operations.SingletonConsumerSet.receive
> E File "apache_beam/runners/worker/operations.py", line 707, in
> apache_beam.runners.worker.operations.DoOperation.process
> E File "apache_beam/runners/worker/operations.py", line 708, in
> apache_beam.runners.worker.operations.DoOperation.process
> E File "apache_beam/runners/common.py", line 1200, in
> apache_beam.runners.common.DoFnRunner.process
> E File "apache_beam/runners/common.py", line 1281, in
> apache_beam.runners.common.DoFnRunner._reraise_augmented
> E File "apache_beam/runners/common.py", line 1198, in
> apache_beam.runners.common.DoFnRunner.process
> E File "apache_beam/runners/common.py", line 537, in
> apache_beam.runners.common.SimpleInvoker.invoke_process
> E File
> "/usr/local/lib/python3.7/site-packages/apache_beam/io/gcp/experimental/spannerio.py",
> line 1251, in process
> E self.service_metric.call('ok')
> E AttributeError: 'NoneType' object has no attribute 'call' [while
> running 'WriteToSpanner/Writing to spanner']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
