[
https://issues.apache.org/jira/browse/BEAM-7010?focusedWorklogId=224314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224314
]
ASF GitHub Bot logged work on BEAM-7010:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/19 12:55
Start Date: 08/Apr/19 12:55
Worklog Time Spent: 10m
Work Description: kanterov commented on issue #8230: [BEAM-7010]
MAX/MIN(STRING)
URL: https://github.com/apache/beam/pull/8230#issuecomment-480819952
LGTM
As a side note, I don't see aggregation tests verifying that aggregation
works, because it always uses the input of a single row, and verifies that it
doesn't change. I see there is `BeamSqlDslSqlStdOperatorsTest` that allows
doing that. Can you fix that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 224314)
Time Spent: 40m (was: 0.5h)
> MAX/MIN(STRING)
> ---------------
>
> Key: BEAM-7010
> URL: https://issues.apache.org/jira/browse/BEAM-7010
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java#L108
> BeamSQL does not accept STRING as MIN/MAX's input parameter type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
