[
https://issues.apache.org/jira/browse/BEAM-8388?focusedWorklogId=737521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737521
]
ASF GitHub Bot logged work on BEAM-8388:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/22 14:07
Start Date: 07/Mar/22 14:07
Worklog Time Spent: 10m
Work Description: RustedBones commented on pull request #16271:
URL: https://github.com/apache/beam/pull/16271#issuecomment-1060724353
Sure @aromanenko-dev!
> What are the actual breaking changes? Could you list them?
API breaking changes:
- `AvroCoder`: removing `useReflectApi()` which was introduced in 2.36.0 in
favour of specialized implementations
- `AvroIO`: `writeCustomType` now must be provided with the class of the
output record
- `JodaTimestampConversion` is removed
Runtime breaking changes:
- Current avro coder uses a custom `ReflectData`, initialized with
`JodaTimestampConversion`. This PR will remove this and only use default avro's
`GenericData`, `SpecificData` or `ReflectData`.
Any users that are using avro 1.9 would need to manually add joda conversion
to be able to support schemas compiled with avro 1.8 (time logical types have
been migrated to `java.time`).
Any users at use reflect data with `org.joda.time.DateTime` will have to
either use the
[`AvroEncode`](https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/reflect/AvroEncode.html)
annotation or manually add joda conversion as done
[here](https://github.com/apache/beam/blob/26261ecea8bd92b79989c5ed5c3c4efa06823ecf/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/AvroCoderTest.java#L183)
> Are all review comments already addressed and, if not, could you elaborate
why?
This [comment](https://github.com/apache/beam/pull/16271/files#r771263422)
and this [one](https://github.com/apache/beam/pull/16271/files#r771265701) are
not answered. I'm not sure I understood properly. I think the generic codepath
is already covered by `writeCustomTypeToGenericRecords` in the 1st case. In the
2nd case the API aligns with the `Read` ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737521)
Remaining Estimate: 14h 50m (was: 15h)
Time Spent: 9h 10m (was: 9h)
> Update Avro to 1.9.1 from 1.8.2
> -------------------------------
>
> Key: BEAM-8388
> URL: https://issues.apache.org/jira/browse/BEAM-8388
> Project: Beam
> Issue Type: Improvement
> Components: io-java-avro
> Reporter: Jordanna Chord
> Priority: P3
> Original Estimate: 24h
> Time Spent: 9h 10m
> Remaining Estimate: 14h 50m
>
> Update build dependency to 1.9.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
