[
https://issues.apache.org/jira/browse/BEAM-14009?focusedWorklogId=738269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738269
]
ASF GitHub Bot logged work on BEAM-14009:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/22 18:58
Start Date: 08/Mar/22 18:58
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#16981:
URL: https://github.com/apache/beam/pull/16981#discussion_r821974742
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -1418,7 +1418,13 @@ static EnvironmentInfo create(String environmentId,
String containerUrl) {
static void configureSdkHarnessContainerImages(
DataflowPipelineOptions options, RunnerApi.Pipeline pipelineProto, Job
newJob) {
- if (useUnifiedWorker(options)) {
+
+ boolean isDataflowPrimeJob =
+ (options.getDataflowServiceOptions() != null
+ && options.getDataflowServiceOptions().contains("enable_prime"));
Review comment:
Yeah, seems like we can just remove this check after a Dataflow service
change. Will re-send this for review after the service change is fully deployed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 738269)
Time Spent: 3h (was: 2h 50m)
> Set sdk_harness_container_images for Dataflow Prime jobs
> --------------------------------------------------------
>
> Key: BEAM-14009
> URL: https://issues.apache.org/jira/browse/BEAM-14009
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This will add correct bits to the Dataflow job request so that Dataflow Prime
> jobs take the new container setup code path in Dataflow.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
