[ 
https://issues.apache.org/jira/browse/BEAM-12447?focusedWorklogId=738403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738403
 ]

ASF GitHub Bot logged work on BEAM-12447:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Mar/22 22:07
            Start Date: 08/Mar/22 22:07
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #17032:
URL: https://github.com/apache/beam/pull/17032#discussion_r822113903



##########
File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py
##########
@@ -338,3 +345,24 @@ def _get_gcs_bucket_and_name(gcs_location):
   def _make_tarfile(output_filename, source_dir):
     with tarfile.open(output_filename, "w:gz") as tar:
       tar.add(source_dir, arcname=SOURCE_FOLDER)
+
+  @staticmethod
+  def _get_cloud_build_machine_type_enum(machine_type: str):
+    if not machine_type:
+      return None
+    mappings = {
+        'n1-highcpu-8': cloudbuild.BuildOptions.MachineTypeValueValuesEnum.

Review comment:
       And could you remind me please when this becomes a problem?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 738403)
    Time Spent: 3h  (was: 2h 50m)

> SdkContainerImageBuilder should take machineType configs
> --------------------------------------------------------
>
>                 Key: BEAM-12447
>                 URL: https://issues.apache.org/jira/browse/BEAM-12447
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow, sdk-py-core
>            Reporter: Yichi Zhang
>            Priority: P3
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> When prebuilding the python SDK container harness image with 
> SdkContainerImageBuilder on google cloud build, it can run out of memory and 
> fail the build with docker exit code 137. The default machineType is only 
> n1-standard-1 and it is unlikely sufficient to build large images.
>  
> The SdkContainerImageBuilder should take additional machineType configs to 
> circumvent the docker OOM issue.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to