[
https://issues.apache.org/jira/browse/BEAM-10529?focusedWorklogId=738854&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738854
]
ASF GitHub Bot logged work on BEAM-10529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 15:42
Start Date: 09/Mar/22 15:42
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16923:
URL: https://github.com/apache/beam/pull/16923#discussion_r822780069
##########
File path: sdks/go/pkg/beam/core/graph/coder/coder.go
##########
@@ -440,3 +454,9 @@ func checkCodersNotNil(list []*Coder) {
}
}
}
+
+func checkCoderNotNil(c *Coder, outercoder string) {
Review comment:
Having this function take the singular name for the helper that was
already written is a little unclear since the signature takes the outer coder
name as a debug string. You could route the check through the existing helper
since the stack trace will indicate that it was a nil coder being passed to
NewN()
##########
File path: sdks/go/pkg/beam/core/graph/coder/coder_test.go
##########
@@ -517,6 +524,59 @@ func TestNewKV(t *testing.T) {
}
}
+func TestNewNullable(t *testing.T) {
+ bytes := NewBytes()
+
+ tests := []struct {
+ name string
+ component *Coder
+ shouldpanic bool
+ want *Coder
+ }{{
Review comment:
Fix formatting here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 738854)
Time Spent: 5h (was: 4h 50m)
> Kafka XLang fails for ?empty? key/values
> ----------------------------------------
>
> Key: BEAM-10529
> URL: https://issues.apache.org/jira/browse/BEAM-10529
> Project: Beam
> Issue Type: Bug
> Components: cross-language, io-java-kafka
> Reporter: Luke Cwik
> Assignee: John Casey
> Priority: P1
> Time Spent: 5h
> Remaining Estimate: 0h
>
> It looks like the Javadoc for ByteArrayDeserializer and StringDeserializer
> can return null[1, 2] and we aren't using
> NullableCoder.of(ByteArrayCoder.of()) in the expansion[3]. Note that KafkaIO
> does this correctly in its regular coder inference logic[4].
> 1:
> [https://kafka.apache.org/21/javadoc/org/apache/kafka/common/serialization/ByteArrayDeserializer.html#deserialize-java.lang.String-byte:A-|https://kafka.apache.org/21/javadoc/org/apache/kafka/common/serialization/ByteArrayDeserializer.html#deserialize-java.lang.String-byte:A-2:]
> [2:|https://kafka.apache.org/21/javadoc/org/apache/kafka/common/serialization/ByteArrayDeserializer.html#deserialize-java.lang.String-byte:A-2:]
>
> [https://kafka.apache.org/21/javadoc/org/apache/kafka/common/serialization/StringDeserializer.html#deserialize-java.lang.String-byte:A-]
> 3:
> [https://github.com/apache/beam/blob/af2d6b0379d64b522ecb769d88e9e7e7b8900208/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java#L478]
> 4:
> [https://github.com/apache/beam/blob/af2d6b0379d64b522ecb769d88e9e7e7b8900208/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/LocalDeserializerProvider.java#L85]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
