[
https://issues.apache.org/jira/browse/BEAM-13925?focusedWorklogId=739225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739225
]
ASF GitHub Bot logged work on BEAM-13925:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/22 01:21
Start Date: 10/Mar/22 01:21
Worklog Time Spent: 10m
Work Description: damccorm commented on a change in pull request #17062:
URL: https://github.com/apache/beam/pull/17062#discussion_r823252162
##########
File path: scripts/ci/pr-bot/processNewPrs.ts
##########
@@ -163,6 +172,59 @@ async function processPull(
console.log(`Processing PR ${pull.number}`);
+ // If reviewers are already assigned, we just need to check if we should
assign a committer.
+ if (Object.keys(prState.reviewersAssignedForLabels).length > 0) {
+ if (prState.committerAssigned) {
+ console.log(
+ `Skipping PR ${pull.number} because a committer has been assigned`
+ );
+ return;
+ }
+
+ const approvers = await approvedBy(pull);
+ if (!approvers || approvers.length == 0) {
+ console.log(
+ `Skipping PR ${pull.number} because reviewers are assigned but haven't
approved`
+ );
+ return;
+ }
+
+ // TODO(BEAM-13925) - also check if the author is a committer, if they are
don't auto-assign a committer
+ for (const approver of approvers) {
Review comment:
Note that the below block of code was moved from processPrUpdate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 739225)
Time Spent: 14h 40m (was: 14.5h)
> Automate Reviewer Assignment
> ----------------------------
>
> Key: BEAM-13925
> URL: https://issues.apache.org/jira/browse/BEAM-13925
> Project: Beam
> Issue Type: Improvement
> Components: beam-community
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 14h 40m
> Remaining Estimate: 0h
>
> Right now, we don't have a well defined automated system for staying on top
> of pull request reviews - we rely on contributors being able to find the
> correct OWNERS file and committers manually triaging/calling attention to old
> pull requests. We should add automation driven by GitHub Actions to
> automatically round robin new PR reviews to a set of contributors, thus
> balancing the load.
>
> Design doc here -
> https://docs.google.com/document/d/1FhRPRD6VXkYlLAPhNfZB7y2Yese2FCWBzjx67d3TjBo/edit#
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
