[ 
https://issues.apache.org/jira/browse/BEAM-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812906#comment-16812906
 ] 

Thomas Weise commented on BEAM-7035:
------------------------------------

This change is necessary but I don't think clearing a timer can actually work 
through the fn api.

[~mxm] there isn't anything on the Flink runner side that I can find starting 
from here: 
[https://github.com/apache/beam/blob/4e39c01c2319a06142bd7d578e90a82537463716/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java#L658]

and there is also no Python side encoding for the clear parameter in 
TimerCoderImpl 

 

> Clear() method of OutputTimer is inconsistent
> ---------------------------------------------
>
>                 Key: BEAM-7035
>                 URL: https://issues.apache.org/jira/browse/BEAM-7035
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model
>            Reporter: Rakesh Kumar
>            Assignee: Rakesh Kumar
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [Clear()|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/bundle_processor.py#L378]
>  method of OutputTimer is not consistent () 
> The timestamp parameter is passed here but never used. Also in the [test 
> cases 
> |[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/userstate_test.py#L501]]
>  and direct runner timer doesn't pass any parameter in the clear method



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to