[
https://issues.apache.org/jira/browse/BEAM-14091?focusedWorklogId=741193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741193
]
ASF GitHub Bot logged work on BEAM-14091:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/22 20:03
Start Date: 14/Mar/22 20:03
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #17072:
URL: https://github.com/apache/beam/pull/17072#issuecomment-1064694432
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17072](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(ce0e3a0) into
[master](https://codecov.io/gh/apache/beam/commit/bdc3162dfaa76a26de3d9c0bdbfe0d2511f34424?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(bdc3162) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ce0e3a0 differs from pull request most recent
head 162d0a1. Consider uploading reports for the commit 162d0a1 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17072 +/- ##
==========================================
+ Coverage 73.79% 73.88% +0.09%
==========================================
Files 663 663
Lines 87056 87767 +711
==========================================
+ Hits 64243 64847 +604
- Misses 21729 21836 +107
Partials 1084 1084
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.63% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `80.93% <ø> (-0.25%)` | :arrow_down: |
|
[...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==)
| `95.07% <ø> (-1.48%)` | :arrow_down: |
|
[...nternal/clients/cloudbuild/cloudbuild\_v1\_client.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2Nsb3VkYnVpbGQvY2xvdWRidWlsZF92MV9jbGllbnQucHk=)
| `52.21% <0.00%> (-2.97%)` | :arrow_down: |
|
[...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=)
| `37.93% <0.00%> (-1.02%)` | :arrow_down: |
|
[...eam/runners/interactive/caching/streaming\_cache.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL3N0cmVhbWluZ19jYWNoZS5weQ==)
| `95.81% <0.00%> (-0.84%)` | :arrow_down: |
|
[...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=)
| `85.85% <0.00%> (-0.51%)` | :arrow_down: |
|
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
| `92.02% <0.00%> (-0.46%)` | :arrow_down: |
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `94.85% <0.00%> (-0.43%)` | :arrow_down: |
| ... and [16
more](https://codecov.io/gh/apache/beam/pull/17072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[bdc3162...162d0a1](https://codecov.io/gh/apache/beam/pull/17072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 741193)
Time Spent: 2h 20m (was: 2h 10m)
> Fixing Interactive Beam show/collect for remote runners
> -------------------------------------------------------
>
> Key: BEAM-14091
> URL: https://issues.apache.org/jira/browse/BEAM-14091
> Project: Beam
> Issue Type: Bug
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> * Bug: the show and collect commands under Interactive Beam would eventually
> call a PipelineFragment to execute the InteractiveRunner corresponding to the
> given PCollection. The PipelineFragment by default does not wait for pipeline
> to finish execution, and when a pipeline runs remotely, the Interactive
> Environment is not updated with the results of the pipeline run. Subsequent
> calls to ib.show/ib.collect would rerun the pipeline instead of directly
> retrieving the results from the Interactive Environment.
> * Setting the blocking to always be True inside the
> RecordingManager.record() method when calling the .run() method of the
> PipelineFragment properly saves completed pipeline results in the Interactive
> Environment and prevents a need to rerun the pipelines again on subsequent
> calls to ib.show/ib.collect.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
