[ 
https://issues.apache.org/jira/browse/BEAM-6936?focusedWorklogId=224879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224879
 ]

ASF GitHub Bot logged work on BEAM-6936:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Apr/19 09:58
            Start Date: 09/Apr/19 09:58
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on pull request #8183: [BEAM-6936] 
Added Jenkins jobs running Java examples on Dataflow with Java 11
URL: https://github.com/apache/beam/pull/8183#discussion_r273409121
 
 

 ##########
 File path: runners/google-cloud-dataflow-java/examples/build.gradle
 ##########
 @@ -42,57 +42,60 @@ def dockerImageName = 
project(':beam-runners-google-cloud-dataflow-java').ext.do
 // If -PuseExecutableStage is set, the use_executable_stage_bundle_execution 
wil be enabled.
 def fnapiExperiments = project.hasProperty('useExecutableStage') ? 
'beam_fn_api,use_executable_stage_bundle_execution' : "beam_fn_api"
 
+// we require dataflowWorker, optional workerHarnessContainerImage and 
optional additionalOptions
+def commonConfig = { dataflowWorkerJar, workerHarnessContainerImage = '', 
additionalOptions = [] ->
+   // return the preevaluated configuration closure
+           return {
 
 Review comment:
   Good catch. It did but IMO it shouldn't have. It looks like no build.gradle 
files are checked only when applyGroovyNature() is invoked in them. Looks like 
a bug.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 224879)
    Time Spent: 3h 40m  (was: 3.5h)

> Add a Jenkins job running Java examples on Java 11 Dataflow
> -----------------------------------------------------------
>
>                 Key: BEAM-6936
>                 URL: https://issues.apache.org/jira/browse/BEAM-6936
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-java, testing
>            Reporter: Michal Walenia
>            Assignee: Michal Walenia
>            Priority: Minor
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to