[
https://issues.apache.org/jira/browse/BEAM-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Huntsperger updated BEAM-5742:
------------------------------------
Fix Version/s: Not applicable
Resolution: Won't Fix
Status: Resolved (was: Open)
> Add expectations for code reviews
> ---------------------------------
>
> Key: BEAM-5742
> URL: https://issues.apache.org/jira/browse/BEAM-5742
> Project: Beam
> Issue Type: Sub-task
> Components: website
> Reporter: Scott Wegner
> Priority: P3
> Fix For: Not applicable
>
>
> There should be a dedicated section about how we to code reviews, and
> expectations for contributors / reviewers. Things like:
> * PR's should have linked JIRA
> * Code changes should also include tests
> * Small changes are easier to review
> * How to find a reviewer, when you can expect reviewer to engage
> * How automatic test runs work (PreCommits run by on each commit; build /
> test should be passing before asking for a reviewer)
> * How to re-run tests, and how/when to run Post-Commits
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
